auto-set sort direction on sort type change #1315
Open
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
requested changes
Dec 10, 2024
miles-grant-ibigroup
added
the
BLOCKED
|
Blocked by #1316 |
# Conflicts: # lib/components/form/call-taker/date-time-picker.tsx
|
All is fixed after latest merge! |
miles-grant-ibigroup
removed
the
BLOCKED
binh-dam-ibigroup
approved these changes
Dec 20, 2024
| @@ -32,6 +32,15 @@ export const DepartArriveTypeMap: Record< | |||
| NOW: 'DURATION' | |||
| } | |||
|
|
|||
| export const DepartArriveDirectionMap: Record< | |||
There was a problem hiding this comment.
Maybe rename to DepartArriveDefaultSortMap or something like this, to clarify it is a default setting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets ASC/DESC automatically on changing the sort type.
Do we want this behavior like this by default? Curious for opinions